-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Bump actions/download-artifact from 3 to 4 #179
⬆️ Bump actions/download-artifact from 3 to 4 #179
Conversation
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
=====================================
Coverage 82.2% 82.2%
=====================================
Files 13 13
Lines 1088 1088
=====================================
Hits 895 895
Misses 193 193 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be merged right now. There are some breaking changes in this release and uploaded artifacts are no longer automatically aggregated.
Some solutions and workarounds are circling around. I'll come back to this when I know more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also directly fix the upload artifact action as both actions fundamentally require to be the same version.
As such, it makes sense to deal with the changes in one PR.
This kind of dependency between actions is also the main selling point for dependabot groups. See https://github.com/cda-tum/mqt-core/blob/e10ac104fb1ce5beede0e5d198d6ca26e5e37bb6/.github/dependabot.yml#L6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
@dependabot squash and merge |
Bumps actions/download-artifact from 3 to 4.
Release notes
Sourced from actions/download-artifact's releases.
Commits
7a1cd32
Merge pull request #246 from actions/v4-beta8f32874
licensed cacheb5ff844
Merge pull request #245 from actions/robherley/v4-documentationf07a0f7
Update README.md7226129
update test workflow to use different artifact names for matrixada9446
update docs and bump@actions/artifact
7eafc8b
Merge pull request #244 from actions/robherley/bump-toolkit3132d12
consume latest toolkit5be1d38
Merge pull request #243 from actions/robherley/v4-beta-updates465b526
consume latest@actions/toolkit
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot will merge this PR once CI passes on it, as requested by @nquetschlich.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)