Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 Improved usability of the on-the-fly SiDB gate library #634

Open
wants to merge 85 commits into
base: main
Choose a base branch
from
Open

🎨 Improved usability of the on-the-fly SiDB gate library #634

wants to merge 85 commits into from

Conversation

Drewniok
Copy link
Collaborator

Description

This PR improves the usability of the on-the-fly SiDB gate library. Additionally, several bugs have been fixed.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

actions-user and others added 23 commits December 12, 2024 15:52
@actions-user
📝 Update pyfiction docstrings
9477cf8 
Signed-off-by: GitHub Actions <[email protected]>
@Drewniok
Merge branch 'cda-tum:main' into main
35fed45
@Drewniok
Merge branch 'cda-tum:main' into main
bc905b7
@Drewniok
Merge branch 'cda-tum:main' into main
f188a69
@Drewniok
Merge branch 'cda-tum:main' into main
65ec0a5
@Drewniok
Merge branch 'cda-tum:main' into main
24c2421
@actions-user
📝 Update pyfiction docstrings
4113659 
Signed-off-by: GitHub Actions <[email protected]>
@Drewniok
Merge branch 'cda-tum:main' into main
72e08f4
@Drewniok
Merge branch 'cda-tum:main' into main
dfb71fb
@Drewniok
Merge branch 'cda-tum:main' into main
d5c5ff5
@Drewniok
Merge branch 'cda-tum:main' into main
9d45592
@Drewniok
Merge branch 'cda-tum:main' into main
dfaf039
@Drewniok
🎨 small changes.
09c654e
@Drewniok
✨ add function to count charged and uncharged defects.
da5bc9d
@Drewniok
✅ add test files for apply gate library.
fc096de
@Drewniok
👷 add TEST_PATH to cmake.
ca3f957
@Drewniok
🎨 small changes.
6c4f457
@Drewniok
🎨 restructure code to make the on-the-fly circuit design more accessi…
bc58c7d 
…ble.
@Drewniok
✅ add test for the apply gate library function.
50fc4cc
@Drewniok
✨ add function to detect defects.
593bb30
@Drewniok
🎨 several smaller fixes and changes.
6dd2c89
@Drewniok
🎨 small fix.
0d54041
@actions-user
📝 Update pyfiction docstrings
be59657 
Signed-off-by: GitHub Actions <[email protected]>
@Drewniok Drewniok added the enhancement New feature or request label Jan 15, 2025
@Drewniok Drewniok self-assigned this Jan 15, 2025
Drewniok and others added 5 commits January 15, 2025 17:12
github-actions[bot]
github-actions bot reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

include/fiction/algorithms/physical_design/apply_gate_library.hpp Show resolved Hide resolved
@Drewniok Drewniok requested a review from marcelwa January 31, 2025 17:19
@Drewniok
Copy link
Collaborator Author

Drewniok commented Feb 1, 2025

I think the coverage is pretty good now. What do you think?

marcelwa
marcelwa requested changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments and questions here and there. Nothing critical, as far as I can tell 🙂

test/resources/AND_layout.sqd Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great to have such test resources available. Do you think we can organize them in this folder more meaningfully for easer extension in the future? AND_layout.sqd could be anything. Path and filename don't give away that it is a SiQAD gate (if it is) or what makes it special or what test case it is used for. Maybe I can propose something along the lines of test/resources/simulation/sidb/siqad/AND.sqd. This might not be perfect, so please incorporate changes if required.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right! It is crucial to get more structure here so as not to lose the overview. Thank you!

include/fiction/algorithms/physical_design/on_the_fly_sidb_circuit_design.hpp Outdated Show resolved Hide resolved
include/fiction/algorithms/physical_design/on_the_fly_sidb_circuit_design.hpp Show resolved Hide resolved
include/fiction/algorithms/physical_design/on_the_fly_sidb_circuit_design.hpp Outdated Show resolved Hide resolved
include/fiction/algorithms/physical_design/on_the_fly_sidb_circuit_design.hpp Show resolved Hide resolved
include/fiction/algorithms/physical_design/on_the_fly_sidb_circuit_design.hpp Outdated Show resolved Hide resolved
include/fiction/technology/sidb_surface_analysis.hpp Show resolved Hide resolved
include/fiction/algorithms/physical_design/on_the_fly_sidb_circuit_design.hpp Outdated Show resolved Hide resolved
include/fiction/technology/sidb_on_the_fly_gate_library.hpp Outdated Show resolved Hide resolved
include/fiction/technology/sidb_on_the_fly_gate_library.hpp Outdated Show resolved Hide resolved
@Drewniok Drewniok requested a review from marcelwa February 6, 2025 09:19
@actions-user
📝 Update pyfiction docstrings
4ef728a 
Signed-off-by: GitHub Actions <[email protected]>
github-actions[bot]
github-actions bot reviewed Feb 6, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

include/fiction/algorithms/physical_design/apply_gate_library.hpp Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Feb 6, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

include/fiction/algorithms/simulation/sidb/is_operational.hpp Outdated Show resolved Hide resolved
@Drewniok
Copy link
Collaborator Author

Drewniok commented Feb 7, 2025

@marcelwa I would love to hear your feedback when your time allows it!

@marcelwa
Copy link
Collaborator

marcelwa commented Feb 7, 2025

@marcelwa I would love to hear your feedback when your time allows it!

I'm on it.

marcelwa
marcelwa requested changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As before, just a few minor comments here and there. Should be quick to address.

include/fiction/algorithms/simulation/sidb/is_operational.hpp Outdated Show resolved Hide resolved
docs/algorithms/on_the_fly_circuit_design_on_defective_surface.rst Outdated Show resolved Hide resolved
test/algorithms/physical_design/apply_gate_library.cpp Outdated Show resolved Hide resolved
test/algorithms/physical_design/design_sidb_gates.cpp Show resolved Hide resolved
test/algorithms/physical_design/design_sidb_gates.cpp Show resolved Hide resolved
test/algorithms/physical_design/apply_gate_library.cpp Show resolved Hide resolved
test/algorithms/physical_design/apply_gate_library.cpp Show resolved Hide resolved
test/algorithms/physical_design/apply_gate_library.cpp Show resolved Hide resolved
test/algorithms/physical_design/design_sidb_gates.cpp Show resolved Hide resolved
test/algorithms/physical_design/design_sidb_gates.cpp Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@marcelwa marcelwa marcelwa requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Drewniok Drewniok

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Drewniok @marcelwa @actions-user