ci: use only one workflow everywhere #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least once in every developer's lifetime, you will craft the *perfect* PR that passes all its tests with flying colors. You click that big green merge button with complete confidence… … only to have the post-merge "update the rolling release" job fail hideously, requiring an immediate fix or revert. Blame is passed. Ire is raised. To minimize the chance of this happening, we reduce our CI jobs down to a single workflow. We go ahead and run *all* the release tasks, even for PRs, to make sure they will succeed if we run them "for real." The only jobs that are skipped are the ones which update tags and publish new releases/packages. Everything else runs.
cbs228
force-pushed
the
feature/ci_one_workflow
branch
from
48cc13f to
e5b4319
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least once in every developer's lifetime, you will craft the perfect PR that passes all its tests with flying colors. You click that big green merge button with complete confidence…
… only to have the post-merge "update the rolling release" job fail hideously, requiring an immediate fix or revert. Blame is passed. Ire is raised.
To minimize the chance of this happening, we reduce our CI jobs down to a single workflow. We go ahead and run all the release tasks, even for PRs, to make sure they will succeed if we run them "for real."
The only jobs that are skipped are the ones which update tags and publish new releases/packages. Everything else runs.