-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GLib-critical on start and redraw on seek #28
base: master
Are you sure you want to change the base?
Conversation
Hey I know this isn't the right place to ask, but can you please share precompiled binaries with this fix? I'm on arch linux and the compilation fails with exit status 4 every time, even the Aur package fails to build, likely because it is too old already. |
@Samueru-sama Download snapshot from the AUR, and change the source to: |
I tested this commit and the issue described in #31 is less noticeable, although when spamming fast scrolling DeadBeeF lags much more and CPU usage is greater, in my case from ~4% to 25%, origin spikes to ~14%. |
I can't compile, I get this error: https://pastebin.com/8UXz7DwJ I've tried manually compiling, using the aur packages and now what you recommended, every single time I get the same error, I even asked a friend that uses Ubuntu to try to compile it on their machine and they also had the same error. |
I have fixed this now |
Thank you, I was able to compile it and the issue with the bar is gone as well! |
Fixes the following critical:
(deadbeef:327963): GLib-CRITICAL **: 22:44:42.063: Source ID 23 was not found when attempting to remove it
This happens when deadbeef launches in stopped state.
Also fixes the glitches when seeking by always redrawing on seeks.
edit: I am just piling on changes I want merged here because it improves the plugin. Do as you wish.