get_rank instead of just rank (was failing to install in older python…

… versions)
cavalab · Apr 24, 2024 · 5ee9393 · 5ee9393
1 parent 1341183
commit 5ee9393
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -81,6 +81,8 @@ That means it should be compatible with sklearn pipelines, wrappers, and so fort
 
 In addition, Brush provides functionality that allows you to feed in more complicated data types than just matrices of floating point values. 
 
+<!-- TODO: update these examples (at least check they still work) -->
+
 ## Regression
 
 ```python

diff --git a/src/selection/nsga2.h b/src/selection/nsga2.h
@@ -51,9 +51,9 @@ class NSGA2 : public SelectionOperator<T>
                 auto ind1 = pop.individuals[i];
                 auto ind2 = pop.individuals[j];
 
-                if (ind1->fitness.rank < ind2->fitness.rank)
+                if (ind1->fitness.get_rank() < ind2->fitness.get_rank())
                     return true;
-                else if (ind1->fitness.rank == ind2->fitness.rank &&
+                else if (ind1->fitness.get_rank() == ind2->fitness.get_rank() &&
                             ind1->fitness.crowding_dist > ind2->fitness.crowding_dist)
                     return true;
                 return false;

diff --git a/tests/cpp/test_brush.cpp b/tests/cpp/test_brush.cpp
@@ -113,8 +113,6 @@ TEST(Engine, EngineWorks)
     est_not_div2.run(data);
 
     // TODO: test predict and predict proba
-
-     // TODO: why isnt this working for classification
      // TODO: validation loss
 }