Add modifiers support for keypress #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@claud-io / @lbartoli79 can you review this PR, it's been pending for 5 months 😮 Thanks! |
|
@jspurlin will try to schedule this for the upcoming weeks |
lbartoli79
approved these changes
Oct 10, 2024
|
@jspurlin allows this change to work, we need to change also UI. We should be able to do it by next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing kepress command does not support modifiers to dispatch a key combination event such as Ctrl+A.
Using Devtools Protocol (https://chromedevtools.github.io/devtools-protocol/tot/Input/) Input.dispatchKeyEvent modifiers, we have added a new value argument where the users can pass Alt, Ctrl or Shift and dispatch key combinations. The new format is:
keypress [tab] key [tab] Alt|Ctrl|Shift.
The new command is backward compatible and works as before if no value passed. In case of passing garbage values, it also ignores them. This is behavior is aligned with Devtools Protocol, when a key combination is at system level, it gets simply ignored.