Summary arg order #281
Merged
Summary arg order #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, I just tested it on R-devel and the tests pass, at least. Check fails for me with some bizarre font issue, but I think it's unrelated |
|
@catavallejos Would it be possible to merge this and push it to Bioconductor? At the moment, any package that depends on {BASiCS} is failing on the devel branch because of this. Thanks! |
|
So sorry for the delay @lazappi and @alanocallaghan . Merged and will push to Bioc now. Best Cata |
|
Hi @lazappi - after pushing I saw there was a small typo in one of the examples that led to errors in BioC. That should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just trying to fix my bioc packages and spotted this along the way. I can't get R 4.4 installed to properly run checks, but it solves one of the issues at least