Fix na.rm functionality for ncol<2

catavallejos · Mar 11, 2024 · 14bc635 · 14bc635
1 parent 3ff33d8
commit 14bc635
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/R/Methods.R b/R/Methods.R
@@ -156,8 +156,7 @@ setMethod("Summary",
         dimnames = list(colnames(n), c("median", "lower", "upper"))
       )
       HPD[, 1] <- colMedians(n, na.rm = na.rm)
-      ind_not_na <- !is.na(HPD[, 1])
-      HPD[ind_not_na, 2:3] <- apply(n[, ind_not_na], 2, function(col) {
+      HPD[, 2:3] <- apply(n, 2, function(col) {
         if (na.rm) {
           col <- na.omit(col)
         }

diff --git a/man/Summary-BASiCS_Chain-method.Rd b/man/Summary-BASiCS_Chain-method.Rd
diff --git a/tests/testthat/test_methods.R b/tests/testthat/test_methods.R
@@ -19,6 +19,8 @@ test_that("Summary na.rm", {
   expect_false(any(is.na(s1@parameters$nu)))
   expect_true(all(is.na(s2@parameters$nu[1, ])))
   expect_true(all(is.na(s2@parameters$nu[4, ])))
+  ChainSC@parameters$nu[1, 1:ncol(ChainSC@parameters$nu)] <- NA
+  expect_error(s3 <- Summary(ChainSC, na.rm = TRUE))
 })
 
 test_that("subset", {