Issue #358: Use pix_icon to render icons #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MWP 4.5Before fix
With initial fix
With latest fix
Totara 13Before regression
After regression
With latest fix
Moodle 3.9Before regression
After regression
With latest fix
|
|
Thanks @djarran Looks good to me. PS: Thanks heaps for providing the detailed screenshots and testing this in various environments. Cheers, |
golenkovm
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This resolves Issue #358 (and fixes subsequent regressions, see #360) by using
pix_iconinstead ofhtml_writer::empty_tag. This simplifies the code by using the core methods of rendering icons.This fixes the original issue in MWP 4.5 and causes no regressions when used in older versions (tested Moodle 3.9, Moodle 4.1, Moodle 4.5, MWP 4.5 and Totara 13)