Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sec distribution fix #4031

Merged
merged 3 commits into from
Jan 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/pudl/analysis/pudl_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def get_model_tables() -> list[str]:
"core_sec10k__company_information",
"core_sec10k__exhibit_21_company_ownership",
"core_sec10k__filings",
"out_sec_10k__parents_and_subsidiaries",
"out_sec10k__parents_and_subsidiaries",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make names consistent

]

return pudl_models_tables
Expand All @@ -31,7 +31,8 @@ def pudl_models_asset_factory(table_name: str) -> AssetsDefinition:

@asset(
name=table_name,
io_manager_key="pudl_io_manager",
io_manager_key="parquet_io_manager",
group_name="pudl_models",
)
def _asset() -> pd.DataFrame:
return DeltaTable(_get_table_uri(table_name)).to_pandas()
Expand Down
1 change: 1 addition & 0 deletions src/pudl/metadata/classes.py
Original file line number Diff line number Diff line change
Expand Up @@ -1486,6 +1486,7 @@ def from_pyarrow_schema(
name=name,
description=description,
schema=Schema.from_pyarrow_schema(schema),
create_database_schema=False,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't include PUDL models tables in sqlite schema

)

def get_field(self, name: str) -> Field:
Expand Down
Loading