Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix row count asset check for vcerare #3993

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Fix row count asset check for vcerare #3993

merged 4 commits into from
Dec 20, 2024

Conversation

zschira
Copy link
Member

@zschira zschira commented Dec 19, 2024

Overview

This PR fixes the VCERARE row count asset_check. This check was using the expected row count for the full ETL, and would fail for the fast ETL. Now it handles both correctly.

@zschira zschira requested a review from jdangerx December 19, 2024 22:46
@zschira zschira self-assigned this Dec 19, 2024
Copy link
Member

@jdangerx jdangerx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you!

Also tiny typo fix. But otherwise good to go!

src/pudl/transform/vcerare.py Outdated Show resolved Hide resolved
src/pudl/transform/vcerare.py Outdated Show resolved Hide resolved
@jdangerx jdangerx changed the base branch from main to 3928-asset-checks-run-again December 19, 2024 22:49
@jdangerx jdangerx changed the base branch from 3928-asset-checks-run-again to main December 19, 2024 22:49
zschira and others added 2 commits December 19, 2024 17:49
Co-authored-by: Dazhong Xia <[email protected]>
Co-authored-by: Dazhong Xia <[email protected]>
@zschira
Copy link
Member Author

zschira commented Dec 19, 2024

lol expectedededed

@zschira zschira enabled auto-merge December 19, 2024 22:50
@zschira zschira added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit d6e385c Dec 20, 2024
17 checks passed
@zschira zschira deleted the fix_vce_row_count branch December 20, 2024 00:24
@zaneselvans zaneselvans added data-validation Issues related to checking whether data meets our quality expectations. vcerare Pertaining to Vibrant Clean Energy's Resource Adequacy Renewable Energy Power datasets bug Things that are just plain broken. labels Jan 6, 2025
@zaneselvans zaneselvans linked an issue Jan 6, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things that are just plain broken. data-validation Issues related to checking whether data meets our quality expectations. vcerare Pertaining to Vibrant Clean Energy's Resource Adequacy Renewable Energy Power datasets
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Refactor VCE RARE asset checks
3 participants