Filter FERC714 ETL by year #2649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #2649 +/- ##
=======================================
- Coverage 87.1% 87.1% -0.1%
=======================================
Files 86 86
Lines 10001 10004 +3
=======================================
+ Hits 8716 8717 +1
- Misses 1285 1287 +2
☔ View full report in Codecov by Sentry. |
2 tasks
zschira
approved these changes
Jun 9, 2023
| ds = context.resources.datastore | ||
| ferc714_settings = context.resources.dataset_settings.ferc714 | ||
| years = ", ".join(map(str, ferc714_settings.years)) |
This was referenced Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue partially addresses issue #2628 and blocking issues found in #2550. FERC 714 data is not time-subsetted, with the extractor reading in CSV files that are organized on a per-table basis. This code changes the extraction step to add the ability to filter by year on the
record_yrcolumn, which is present in all tables except for therespondent_id_ferc714table. It also updates the fast ETL to include 2 years of data for the FERC 714 run: 2019 and 2020.While this should not make large performance improvements in the current ETL, this should hopefully help with some of the memory constraints encountered in #2550.
PR Checklist
dev).