Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive EIA NEMS #552

Merged
merged 6 commits into from
Jan 29, 2025
Merged

Archive EIA NEMS #552

merged 6 commits into from
Jan 29, 2025

Conversation

e-belfer
Copy link
Member

@e-belfer e-belfer commented Jan 28, 2025

Overview

Closes #521

What problem does this address?
Archive NEMS data & software from the Github repository.

Out of scope:
get_hyperlinks() doesn't return the tag URLs from https://github.com/EIAgov/NEMS/releases correctly, so until #538 merges I'm just hardcoding the specific tag that we're looking for and the year of NEMS data that corresponds to it. See fccf0ff for what an implementation could look like with links pulled from that page.

What did you change in this PR?

  • Add an EIA NEMS archiver

Testing

How did you make sure this worked? How can a reviewer verify this?
pudl_archiver --dataset eianems --sandbox --initialize returns a server 413 error.
Draft production archive can be found here: https://zenodo.org/uploads/14756523

To-do list

Tasks

Preview Give feedback

@e-belfer e-belfer self-assigned this Jan 28, 2025
@e-belfer e-belfer marked this pull request as ready for review January 28, 2025 17:25
Copy link
Member

@cmgosnell cmgosnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! i also get the sandbox error but was able to make another prod deposition which looks right to me. small copy pasta suggestion. Go forth and:

  • publish production archive
  • add doi's to yml
  • add to GHA
  • merrrrrge

Comment on lines 26 to 30
crosswalk_urls = {
"https://github.com/EIAgov/NEMS/archive/refs/tags/Initial-GitHub-Release.zip": 2023,
}

for link in crosswalk_urls:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy pasta!

Suggested change
crosswalk_urls = {
"https://github.com/EIAgov/NEMS/archive/refs/tags/Initial-GitHub-Release.zip": 2023,
}
for link in crosswalk_urls:
nems_urls = {
"https://github.com/EIAgov/NEMS/archive/refs/tags/Initial-GitHub-Release.zip": 2023,
}
for link in nems_urls:

@e-belfer e-belfer enabled auto-merge January 29, 2025 18:55
@e-belfer e-belfer merged commit 77d418e into main Jan 29, 2025
3 checks passed
@e-belfer e-belfer deleted the archive-nems branch January 29, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Write an archiver for EIA National Energy Modeling System Input Data
2 participants