Close modal on backdrop press #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adding a way to close the modal on backdrop (grayed area) press.
Fixes #299
How
Adding a
TouchableOpacitycontainer to the modal to handle backdrop press events. To avoid events being triggered from the modal content, I wrapped this up in aTouchableWithoutFeedback.Tested on Android and iPhone simulators.
Questions
Currently, the backdrop press will invoke the close callback, which is what I think we'd want in most situation, but I don't know of all the use cases. We could alternatively add a callback prop to all modal usages where it makes sense.