Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix "Rule should start at 2" bug in MemoryAdapter::load_policy() #360

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

liulifox233
Copy link
Contributor

Rule should start at 2.

Copy link

github-actions bot commented Jan 6, 2025

Benchmark for d01ccdc

Click to view benchmark
Test PR Benchmark Master Benchmark %
b_benchmark_rbac_model_large 10.9±0.05ms 10.0±0.13ms +9.00%
benchmark priority model 4.2±0.08µs 4.2±0.04µs 0.00%
benchmark_abac_model 2.4±0.04µs 2.5±0.05µs -4.00%
benchmark_basic_model 3.7±0.04µs 3.9±0.04µs -5.13%
benchmark_key_match 6.8±0.14µs 6.7±0.10µs +1.49%
benchmark_raw 0.0±0.00ns 0.0±0.00ns NaN%
benchmark_rbac_model 6.2±0.09µs 6.1±0.07µs +1.64%
benchmark_rbac_model_medium 953.0±7.03µs 854.9±12.62µs +11.48%
benchmark_rbac_model_with_domains 5.8±0.06µs 6.0±0.12µs -3.33%
benchmark_rbac_with_deny 8.7±0.10µs 8.3±0.11µs +4.82%
benchmark_rbac_with_resource_roles 4.4±0.07µs 4.4±0.06µs 0.00%
benchmark_role_manager_large 4.5±0.15ms 4.6±0.08ms -2.17%
benchmark_role_manager_medium 305.7±4.32µs 305.6±5.30µs +0.03%
benchmark_role_manager_small 98.2±1.32µs 89.5±1.45µs +9.72%

@hsluoyz hsluoyz changed the title fix: fix MemoryAdapter::load_policy() feat: fix "Rule should start at 2" bug in MemoryAdapter::load_policy() Jan 6, 2025
@hsluoyz hsluoyz merged commit c1d9378 into casbin:master Jan 6, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants