Transition to casacore 3.6.1 #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d CountedPtr, code now builds against casacore-3.6.1
…triction, replaced PtrHolder with std::unique_ptr
|
It looks like CI failed. Based on the error message, it looks like it tries to compile casarest against the old casacore (and there was an interface change) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal changes to get casarest to build under the new 3.6.1 casacore (many more improvements are theoretically possible, if we had more resources to maintain this code). The changes caused by the relocation of some static methods to TableUtil, which were made at the time of casacore-3.5 transition but remained stashed on a branch (because they were incompatible with casacore-3.5), are also included in this PR. Also minor improvements to the cmake file, e.g. to remove C++ standard limitations which are no longer required by the current casacore.