Issue 928 #934
Merged
Issue 928 #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernstvonoelsen
force-pushed
the
issue-928
branch
from
f89f70a to
2ed4e9b
Compare
| @@ -47,6 +47,12 @@ func NewSortedFilesFromPaths(paths []string, opts SymlinkAllowOpts) ([]*File, er | |||
|
|
|||
| relativePath := "" | |||
| pathPieces := strings.Split(path, "=") | |||
| if strings.HasPrefix(pathPieces[0], "http://") || strings.HasPrefix(pathPieces[0], "https://") { | |||
| pathPieces = []string{path} | |||
| } else if len(pathPieces) > 1 && (strings.HasPrefix(pathPieces[1], "http://") || strings.HasPrefix(pathPieces[1], "https://")) { | |||
There was a problem hiding this comment.
What is the scenario where this if statement is triggered?
There was a problem hiding this comment.
@joaopapereira this is a safetynet for the use case that the file's path is overwritten on the command line; cf. the case 2 part in L60.
Example: want to cover both scenarios of
path = "myOverwrittenPath=https://example.com?hello=world"path = "https://example.com?hello=world"
joaopapereira
requested changes
Jan 24, 2025
Signed-off-by: Ernst von Oelsen <[email protected]>
Signed-off-by: Ernst von Oelsen <[email protected]>
Signed-off-by: Ernst von Oelsen <[email protected]>
ernstvonoelsen
force-pushed
the
issue-928
branch
from
2ed4e9b to
04ac63b
Compare
|
@joaopapereira done ✔️ for an e2e test, cf. my comment in the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
targets resolution of #928.