Make sure array Helm values always get an items field in OpenAPI schema
#1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcapizzi
changed the title
items field in OpenAPI schema
The `items` field in OpenAPI schema is required, this makes sure that we always add it, even if the default value is an empty array. Fixes carvel-dev#1464. Signed-off-by: Giuseppe Capizzi <[email protected]>
gcapizzi
force-pushed
the
fix-empty-array-items
branch
from
0b5dccb to
2c641ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
itemsfield in OpenAPI schema is required. This makes sure that we always add it, even if the default value is an empty array.Which issue(s) this PR fixes:
Fixes #1464.
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
Relevant docs in this repo added or updatedRelevant carvel.dev docs added or updated in a separate PR and there's a link to that PR