-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding properties #1
Conversation
…alidation against invalid characters RFC-9110
@breakponchito Thanks for your PR! It seems good to activate the validation function with properties. Here are some review items below.
There are some concerns about header value validation.
|
I think I can make some additional edits based on your PR regarding my comment mentioned above. @breakponchito |
+ Added the validation of HTTP header values + Name and value's validation are provided as options. (Improved based on #1 @breakponchito)
@breakponchito Thanks. I've applied it with some modifications based on your PR. Feel free to check it out later! 6bb7eab |
+ Added the validation of HTTP header values + Name and value's validation are provided as options. (Improved based on carryel#1 @breakponchito)
+ Added the validation of HTTP header values + Name and value's validation are provided as options. (Improved based on carryel#1 @breakponchito)
+ Added the validation of HTTP header values + Name and value's validation are provided as options. (Improved based on carryel#1 @breakponchito)
I created the following PR to make a proposal to include two properties to enable the validations for the Issue eclipse-ee4j#2212 on top of the first PR added by @carryel eclipse-ee4j#2213
The proposal is to add two properties to enable the validation of the invalid characters on Header Name, Header Value or both.
I think this probable could be a good strategy to prevent any backward compatibility issue. By default both properties are set as false:
@carryel please check