soft delete for puzzles #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawxfish
force-pushed
the
soft_delete
branch
2 times, most recently
from
4cf4295 to
eb31bf5
Compare
rgossiaux
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes puzzle, answers, and chatrooms models with soft deletion, so deletes are undoable. PuzzleTag is left as a normal model, because there are uniqueness constraints on them, but
PuzzleTag.objectsdoesn't pick up soft deleted instances so would be sorta annoying to check every time we create a new tag that there isn't a soft deleted one already. Instead I handled deleting/restoring tags through signals.Also adds 30 minute wait before cleaning up chats (fixes #548)