fix discord button background #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgossiaux
reviewed
Dec 18, 2024
| @@ -211,8 +213,8 @@ export const LinkCell = ({ row }) => { | |||
| ) : loadingDiscord ? ( | |||
| <PulsingBlurpleDiscordSvg /> | |||
| ) : ( | |||
| <button | |||
| onclick={createDiscordChannels} | |||
| <a | |||
There was a problem hiding this comment.
I think I told akira to use a button instead of so maybe that's why it broke. What was wrong with ?
There was a problem hiding this comment.
The button inherits a bunch of Bootstrap styling that adds the ugly background color and border... that whole cell of buttons uses links instead of buttons for this reason, I guess the right thing to do is switch all of them to buttons and override the Bootstrap styling... I sometimes wonder if we should replace Bootstrap with something less opinionated...
There was a problem hiding this comment.
Ahhhhh ok. Ok sounds good. Yeah we should definitely just get rid of bootstrap lol
rgossiaux
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a small border to make the disabled version of the button stand out more in light mode against the green and red backgrounds of solved and stuck puzzles.
Light mode:
Dark mode:
