Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Extension to Remove Hard Coded Constants and Add some Features #811

Merged
merged 11 commits into from
Jan 3, 2025

Conversation

maximized
Copy link
Contributor

No description provided.

@maximized
Copy link
Contributor Author

Just testing stuff after I broken my Github authentication

@maximized
Copy link
Contributor Author

Changes:

  1. After you click "Add Puzzle", a message appears saying that the puzzle has been created and the extension starts polling Cardboard to wait for the sheet to be created. Once the sheet is created, a link to the sheet appears in the extension pop-up.

  2. If you open the extension on a puzzle page for a puzzle that has already been created, the extension says that the puzzle already exists and includes a link to the sheet.

  3. When you load the hunt page on Cardboard, a message is sent to the extension with the Cardboard URL and hunt id. Then, when you click on the extension, it shows you which hunt you are currently connected to above the "Add Puzzle" button. You can change the hunt you are connected to by going back to Cardboard and opening a new hunt page. There is a tooltip in the extension saying approximately this.

This screen capture shows off the changes and the flow. https://drive.google.com/file/d/1PHDquKq8zhHWUY4dx5JpSwQnu4vDO7pg/view

@maximized maximized marked this pull request as ready for review January 2, 2025 05:18
@maximized
Copy link
Contributor Author

Also changed the title limit to 80 to match the backend.

Copy link
Collaborator

@npinsker npinsker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didn't test and run this (am trusting the video) but, assuming it doesn't crash, this all looks amazing!! -- thanks :D

hunts/src/App.js Outdated Show resolved Hide resolved
@maximized maximized merged commit 83a054a into main Jan 3, 2025
2 checks passed
@maximized maximized deleted the max_cardboard_features branch January 3, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants