Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCM Readme & Henridv's FCM Apple Support #5

Merged
merged 10 commits into from
Aug 22, 2024

Conversation

requiemformemories
Copy link

@requiemformemories requiemformemories commented Aug 22, 2024

original PR: https://github.com/rpush/rpush/pull/664/files

This branch fixes some of the tests, adds README, and adjusts FCM delivery. I think we might need changes on this branch as well.

@requiemformemories requiemformemories changed the title Fcm support v2 FCM Readme & Henridv's FCM Apple Support Aug 22, 2024
@@ -11,7 +11,7 @@ PATH
railties
rainbow
thor (>= 0.18.1, < 2.0)
webpush (~> 1.0)
web-push
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webpush is not updating for 4 years. web-push seems to have better maintainability.

@requiemformemories requiemformemories merged commit 87b52df into cardinalblue:master Aug 22, 2024
0 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants