Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update CI test.yml to use newest version of the dependencies #11

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

requiemformemories
Copy link

@requiemformemories requiemformemories commented Aug 28, 2024

Currently, the CI tests are encountering numerous failures. Based on our observations:

  • If unit and functional tests are run together, 30 functional tests fail.
  • If run separately, they pass in the local environment but fail in the CI environment (the following four).
  • ActiveRecord tests can pass but frequently timeout.

Therefore, we are making the following adjustments:

  • Separate the unit and functional tests in CI.
  • Cancel ActiveRecord tests to avoid resource consumption. We are not using ActiveRecord as our client as well.

Currently, the following four tests are still failing:

rspec ./spec/functional/pushy_spec.rb:17 # Pushy deliveres a notification successfully
rspec ./spec/functional/pushy_spec.rb:21 # Pushy is expected to change `notification.reload.external_device_id` to "5a622ae5813e2875bfdbe496"
rspec ./spec/functional/webpush_spec.rb:20 # Webpush deliveres a notification successfully
rspec ./spec/functional/webpush_spec.rb:26 # Webpush when delivery failed marks a notification as failed

@requiemformemories requiemformemories force-pushed the test/fix-ci-errors branch 4 times, most recently from 67ae9e0 to fb9e7e2 Compare August 28, 2024 10:13
test: split tests with directories

build: remove active_record from ci workflow
@requiemformemories requiemformemories merged commit 5df9199 into master Aug 29, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant