-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): delete related notifications when deleting identifier #971
Open
iFergal
wants to merge
14
commits into
main
Choose a base branch
from
feat/DTIS-1914-Delete-related-notifications-when-deleting-identifier
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(core): delete related notifications when deleting identifier #971
iFergal
wants to merge
14
commits into
main
from
feat/DTIS-1914-Delete-related-notifications-when-deleting-identifier
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l-notification-re-process-idempotency
…ion-re-process-idempotency' into feat/DTIS-1914-Delete-related-notifications-when-deleting-identifier
…ion-re-process-idempotency' into feat/DTIS-1914-Delete-related-notifications-when-deleting-identifier
jimcase
reviewed
Feb 23, 2025
Base automatically changed from
feat/DTIS-1446-General-notification-re-process-idempotency
to
main
February 24, 2025 12:47
…-related-notifications-when-deleting-identifier
jimcase
approved these changes
Feb 24, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We generally cannot act on notifications that relate to deleted identifiers, and we shouldn't anyway. #969 skips any incoming notifications related to deleted identifiers, and handles long running operations that complete which are related to deleted identifiers.
This PR will delete all notification records that are related to an identifier being deleted (and the local group member too, if applicable). This way the user cannot get into an error state acting on old notifications. Also included is a small cleanup in general.
Finally, I also decided we should sync deleted identifiers locally. We soft delete identifiers for historical reasons, so they should be re-synced because other areas of the code assumes the identifier metadata record might exist. We can refactor in the future to fully delete instead of soft deleting and handle the idempotency.
For example, if you delete a group and the local group member identifier has been marked as deleted on the cloud, but fails from there on/crashes, and then you recover on a new device, if you try to delete the group again it will fail as it assumes there's a local group member identifier record in the local DB. This fixes that edge case.
Checklist before requesting a review
Issue ticket number and link
Testing & Validation