-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependency constraints on local-cluster
#4997
Add dependency constraints on local-cluster
#4997
Conversation
101d558
to
83eb802
Compare
The other uses of `extra` are kept due to semantics of `withTempFile`.
83eb802
to
aed3d94
Compare
@@ -263,7 +257,7 @@ anyFunds mnemonicRange mlength style start end networkTag= FaucetM $ do | |||
end | |||
pure $ ias <&> \ia -> | |||
(unFaucetAddress . unIndexedAddress $ ia) | |||
concatMapM run' $ enumRange mnemonicRange | |||
concat <$> mapM run' (enumRange mnemonicRange) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -570,7 +564,7 @@ hwLedgerFunds networkTag = do | |||
addrXPrv = deriveAddressPrivateKey accXPrv Icarus.UTxOExternal | |||
paymentKeyIxs :: [Index (AddressIndexDerivationType Icarus) PaymentK] = | |||
let firstIx = minBound | |||
in firstIx : unfoldr (fmap dupe . nextIndex) firstIx | |||
in firstIx : unfoldr (fmap (\x -> (x, x)) . nextIndex) firstIx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
, typed-process >= 0.2.12.0 && < 0.3 | ||
, unliftio >= 0.2.25 && < 0.3 | ||
-- newer versions of warp depend on crypton | ||
, warp >= 3.3.25 && < 3.3.26 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
This pull request adds dependency constraints to the
local-cluster
package, as this package is a likely target for releasing on CHaP.Where appropriate, we also remove the direct dependency on the following packages
extra
because these dependencies do not cross the Fairbairn threshold.
Issues
#4958