Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency constraints on local-cluster #4997

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

HeinrichApfelmus
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus commented Feb 22, 2025

This pull request adds dependency constraints to the local-cluster package, as this package is a likely target for releasing on CHaP.

Where appropriate, we also remove the direct dependency on the following packages

  • extra

because these dependencies do not cross the Fairbairn threshold.

Issues

#4958

@HeinrichApfelmus HeinrichApfelmus self-assigned this Feb 22, 2025
@HeinrichApfelmus HeinrichApfelmus force-pushed the HeinrichApfelmus/constraints-local-cluster branch from 101d558 to 83eb802 Compare February 22, 2025 12:40
@HeinrichApfelmus HeinrichApfelmus marked this pull request as ready for review February 22, 2025 12:41
@HeinrichApfelmus HeinrichApfelmus force-pushed the HeinrichApfelmus/constraints-local-cluster branch from 83eb802 to aed3d94 Compare February 24, 2025 16:07
@@ -263,7 +257,7 @@ anyFunds mnemonicRange mlength style start end networkTag= FaucetM $ do
end
pure $ ias <&> \ia ->
(unFaucetAddress . unIndexedAddress $ ia)
concatMapM run' $ enumRange mnemonicRange
concat <$> mapM run' (enumRange mnemonicRange)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -570,7 +564,7 @@ hwLedgerFunds networkTag = do
addrXPrv = deriveAddressPrivateKey accXPrv Icarus.UTxOExternal
paymentKeyIxs :: [Index (AddressIndexDerivationType Icarus) PaymentK] =
let firstIx = minBound
in firstIx : unfoldr (fmap dupe . nextIndex) firstIx
in firstIx : unfoldr (fmap (\x -> (x, x)) . nextIndex) firstIx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

, typed-process >= 0.2.12.0 && < 0.3
, unliftio >= 0.2.25 && < 0.3
-- newer versions of warp depend on crypton
, warp >= 3.3.25 && < 3.3.26
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@HeinrichApfelmus HeinrichApfelmus added this pull request to the merge queue Feb 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 26, 2025
@HeinrichApfelmus HeinrichApfelmus added this pull request to the merge queue Feb 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 26, 2025
@HeinrichApfelmus HeinrichApfelmus added this pull request to the merge queue Feb 26, 2025
Merged via the queue into master with commit 790e7e0 Feb 26, 2025
25 checks passed
@HeinrichApfelmus HeinrichApfelmus deleted the HeinrichApfelmus/constraints-local-cluster branch February 26, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants