Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency constraints on cardano-balance-tx #4994

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

HeinrichApfelmus
Copy link
Contributor

This pull request adds dependency constraints to the cardano-balance-tx package, as this package is a likely target for releasing on CHaP.

We also remove the direct dependency on the either package, because it's easy.

@HeinrichApfelmus HeinrichApfelmus self-assigned this Feb 21, 2025
Copy link
Member

@Anviking Anviking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I don't have that much experience or opinions on constraints but this looks reasonable to me!

@HeinrichApfelmus HeinrichApfelmus force-pushed the HeinrichApfelmus/constraints-balance-tx branch from 14baa51 to 13db5c7 Compare February 21, 2025 17:59
@HeinrichApfelmus HeinrichApfelmus added this pull request to the merge queue Feb 21, 2025
Merged via the queue into master with commit 1d7b35b Feb 21, 2025
25 checks passed
@HeinrichApfelmus HeinrichApfelmus deleted the HeinrichApfelmus/constraints-balance-tx branch February 21, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants