Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker image tag naming in case of non-release branches #4951

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Fix docker image tag naming in case of non-release branches #4951

merged 4 commits into from
Jan 23, 2025

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Jan 22, 2025 •
edited
Loading

Changes

  • Add a new flake output to be used in case of building an image on a test branch, .#dockerTestImage
  • Change the way openapi-diff step collects last release tag (just opportunistic as I worked on this kind of code)

Issues

Notes

@paolino paolino self-assigned this Jan 22, 2025
@paolino paolino added CI CI related Improvement Mark a PR as an improvement, for auto-generated CHANGELOG labels Jan 22, 2025
@paolino paolino enabled auto-merge January 22, 2025 16:47
@paolino paolino force-pushed the paolino/4931/have-a-dockerTestImage-ouput-that-uses-test-as-a-tag branch from 7597923 to e67d652 Compare January 22, 2025 17:01
paweljakubas
paweljakubas reviewed Jan 23, 2025
View reviewed changes
nix/docker.nix
@@ -91,7 +91,7 @@ let
# here cardano-wallet.
mainImage = dockerTools.buildImage {
name = repoName;
tag = version;
tag = tag;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it not enough to use just tag; in nix ? 🤔

@paolino paolino added this pull request to the merge queue Jan 23, 2025
paweljakubas
paweljakubas approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice simplifications!

Merged via the queue into master with commit 4a01fd7 Jan 23, 2025
26 checks passed
@paolino paolino deleted the paolino/4931/have-a-dockerTestImage-ouput-that-uses-test-as-a-tag branch January 23, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paweljakubas paweljakubas paweljakubas approved these changes

Assignees

@paolino paolino

Labels
CI CI related Improvement Mark a PR as an improvement, for auto-generated CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parametrize over tag the docker image name definition
2 participants
@paolino @paweljakubas