Add new cardano-wallet-integration:e2e tests running on preprod
#4949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
force-pushed
the
anviking/4931/integration-on-preprod
branch
12 times, most recently
from
59db45d to
6b56cfe
Compare
Anviking
force-pushed
the
anviking/4931/integration-on-preprod
branch
4 times, most recently
from
2092b2c to
e73d952
Compare
Anviking
commented
Feb 4, 2025
Anviking
commented
Feb 4, 2025
Anviking
changed the title
TRANS_CREATE_01x on preprod in new cardano-wallet-integration:e2ecardano-wallet-integration:e2e tests that run on preprod
Anviking
changed the title
cardano-wallet-integration:e2e tests that run on preprodcardano-wallet-integration:e2e tests running on preprod
Anviking
commented
Feb 4, 2025
Anviking
commented
Feb 4, 2025
Anviking
commented
Feb 4, 2025
Anviking
commented
Feb 4, 2025
paolino
requested changes
Feb 4, 2025
Anviking
force-pushed
the
anviking/4931/integration-on-preprod
branch
from
fc41784 to
b0de372
Compare
Anviking
force-pushed
the
anviking/4931/integration-on-preprod
branch
4 times, most recently
from
a0b6386 to
ad91160
Compare
These run on preprod and are to replace both the `wallet-e2e` and ruby e2e tests.
This makes it feasible to have both the node and wallet log to stdout in the cardano-wallet-integration:e2e tests.
Anviking
force-pushed
the
anviking/4931/integration-on-preprod
branch
from
ad91160 to
0420f7d
Compare
- Add `withConfigs` function that reads configs at compile time, writes them to tmp dir with tweaks to tracer verbosity at runtime. - We no longer have to set the E2E_CONFIG_DIR env var - Restore the previous tracer verbosities in configs/cardano/preprod/config.json - Unfortunately we need to duplicate the configs to make it build with haskell.nix. Neither "../.." paths, or "ln -s ../../configs configs" appeared to work.
Anviking
force-pushed
the
anviking/4931/integration-on-preprod
branch
from
0420f7d to
90c4a52
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
) - [x] Add a new `cardano-wallet-integration:e2e` test suite that: - has, and intends to have, a minimal number of tests. It does not want to duplicate everything from `cardano-wallet-integration`. - mostly uses the same `Test.Integration.Framework.DSL` the integration tests are written in - is replacing `lib/wallet-e2e` and is intended to soon replace the ruby e2e tests - [x] Run this `cardano-wallet-integration:e2e` in CI on windows - [new run which hopefully passes like the prev one](https://buildkite.com/cardano-foundation/cardano-wallet/builds/9261#0194d089-3ef3-4f12-85ac-ad68f5a5f0b7) and should now make the stages of the setup appear as sections in the buildkite logs - [x] No longer run ruby e2e tests on win ### Global preprod setup We use only two wallets that are funded with ada. The transaction test will send funds from the richer to the poorer wallet. This should reduce the need for manual involvement as the funds last longer, and in a pinch we could even get by funding just one of the test wallets. ### How to run ```bash export HAL_E2E_PREPROD_MNEMONICS='<mnemonics be found in our vault>' cabal test cardano-wallet-integration:e2e ``` With node and wallet stdout logs manually cleaned: ```bash transactions simple transaction (TRANS_CREATE_01x) [✔] stake pools list some have non-zero rewards, stake, producedBlocks, saturation [✔] some have metadata [‐] # PENDING: metadata fetching not configured; could be enabled ``` ### Issue Number #4931
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
paolino
reviewed
Feb 6, 2025
| @@ -583,6 +583,7 @@ steps: | |||
| depends_on: | |||
| - trigger-windows-e2e-tests | |||
| commands: | |||
| - diff -r configs/cardano/preprod lib/integration/configs/cardano/preprod # ensure the configs don't diverge despite being duplicated | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cardano-wallet-integration:e2etest suite that:cardano-wallet-integration.Test.Integration.Framework.DSLthe integration tests are written inlib/wallet-e2eand is intended to soon replace the ruby e2e testscardano-wallet-integration:e2ein CI on windowsGlobal preprod setup
We use only two wallets that are funded with ada. The transaction test will send funds from the richer to the poorer wallet. This should reduce the need for manual involvement as the funds last longer, and in a pinch we could even get by funding just one of the test wallets.
How to run
With node and wallet stdout logs manually cleaned:
transactions simple transaction (TRANS_CREATE_01x) [✔] stake pools list some have non-zero rewards, stake, producedBlocks, saturation [✔] some have metadata [‐] # PENDING: metadata fetching not configured; could be enabledIssue Number
#4931