Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate docker image push #4937

Merged
merged 7 commits into from
Jan 13, 2025
Merged

Automate docker image push #4937

merged 7 commits into from
Jan 13, 2025

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Jan 10, 2025 •
edited
Loading

Changes

  • Move the push to dockerhub step from the main pipeline to the release one in the nightly group
  • Use a bash script that collect the image from the artifacts to push to dockerhub and respect test and nightly tags
  • Ditch the nix solution to push to dockerhub
  • Add a block before pushing the release tag to dockerhub

Issues

fix #4900

@paolino paolino self-assigned this Jan 10, 2025
@paolino paolino added Improvement Mark a PR as an improvement, for auto-generated CHANGELOG CI CI related Release labels Jan 10, 2025
@paolino paolino force-pushed the paolino/4935/separate-test-from-nightly-tags branch from d17dec2 to 375890f Compare January 10, 2025 17:56
@paolino paolino force-pushed the paolino/4900/automate-docker-image-push-on-release-ci-pipeline branch from 5cee18a to 09862db Compare January 10, 2025 17:57
@paolino paolino force-pushed the paolino/4935/separate-test-from-nightly-tags branch from 2649d66 to f7956f0 Compare January 13, 2025 10:17
@paolino paolino force-pushed the paolino/4900/automate-docker-image-push-on-release-ci-pipeline branch 2 times, most recently from 8c0f581 to e6a9202 Compare January 13, 2025 11:43
@paolino paolino force-pushed the paolino/4935/separate-test-from-nightly-tags branch from f7956f0 to a75091d Compare January 13, 2025 12:05
@paolino paolino force-pushed the paolino/4900/automate-docker-image-push-on-release-ci-pipeline branch 3 times, most recently from b980b5d to c1a71fa Compare January 13, 2025 13:17
@paolino paolino mentioned this pull request Jan 13, 2025
Closed
3 tasks
@paolino paolino force-pushed the paolino/4900/automate-docker-image-push-on-release-ci-pipeline branch from c1a71fa to c164467 Compare January 13, 2025 13:37
@paolino paolino marked this pull request as ready for review January 13, 2025 13:53
paweljakubas
paweljakubas approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! Was not aware of concurrency_group etc. capabilities!

Base automatically changed from paolino/4935/separate-test-from-nightly-tags to master January 13, 2025 16:06
@paolino paolino added this pull request to the merge queue Jan 13, 2025
Merged via the queue into master with commit 5226b92 Jan 13, 2025
24 checks passed
@paolino paolino deleted the paolino/4900/automate-docker-image-push-on-release-ci-pipeline branch January 13, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paweljakubas paweljakubas paweljakubas approved these changes

Assignees

@paolino paolino

Labels
CI CI related Improvement Mark a PR as an improvement, for auto-generated CHANGELOG Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automate docker image push on release CI pipeline
2 participants
@paolino @paweljakubas