Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set dependency bounds in libraries #4958

Open
abailly opened this issue Jan 31, 2025 · 2 comments
Open

Set dependency bounds in libraries #4958

abailly opened this issue Jan 31, 2025 · 2 comments
Assignees
@HeinrichApfelmus
Labels
Dependencies Pull requests that update a dependency file
Milestone
2025Q1

Comments

@abailly
Copy link
Collaborator

abailly commented Jan 31, 2025

Why

When trying to publish cardano-wallet libraries to CHaP, we realised the lack of dependency bounds inside each library's .cabal file is problematic: those dependencies can be updated independently and lead to arbitrary build failures.

The cardano-wallet build works because those bounds are set in cabal.project at the toplevel, but cabal.project is ignored.

What

Fix dependency bounds inside each library's .cabal file, at least on "publishable" libraries : #4411 (comment)
The bounds set there will percolate across the dependency graph to impact the whole build.

How

  • Maintaining bounds individually on each library seems quite painful, would there be a way to automate that
  • Setting too tight bounds might be problematic for wannabe consumers downstream
@abailly abailly added the Dependencies Pull requests that update a dependency file label Jan 31, 2025
@abailly abailly added this to the 2025Q1 milestone Jan 31, 2025
@abailly
Copy link
Collaborator Author

abailly commented Jan 31, 2025

Found this link interesting: https://github.com/wasp-lang/haskell-handbook/blob/master/dependencies-version-bounds.md

@abailly abailly mentioned this issue Jan 31, 2025
Closed
@HeinrichApfelmus HeinrichApfelmus mentioned this issue Feb 4, 2025
Merged
@abailly
Copy link
Collaborator Author

abailly commented Feb 7, 2025

Seems like to complete this we need to complete IntersectMBO/cardano-haskell-packages#1003

@abailly abailly mentioned this issue Feb 10, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 13, 2025
@HeinrichApfelmus
Bump cardano-wallet-agda repository (#4971)
80f3140 
This pull request bumps our use of the `cardano-wallet-agda` repository
to the latest commit.

This entails:

* Bump `cardano-wallet-read` to version `1.0.0.0`, which is the first
version that specifies version constraints in its `.cabal` file.
* Bump `customer-deposit-wallet-pure`. In particular, go back to the
previous definition of `fromXPubAndCount`.

### Issue

#4958
@HeinrichApfelmus HeinrichApfelmus self-assigned this Feb 19, 2025
@HeinrichApfelmus HeinrichApfelmus mentioned this issue Feb 22, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 26, 2025
@HeinrichApfelmus
Add dependency constraints on local-cluster (#4997)
790e7e0 
This pull request adds dependency constraints to the `local-cluster`
package, as this package is a likely target for releasing on CHaP.

Where appropriate, we also remove the direct dependency on the following
packages

* `extra`

because these dependencies do not cross the [Fairbairn
threshold](https://wiki.haskell.org/Fairbairn_threshold).

### Issues

#4958
This was referenced Feb 26, 2025
Merged
Open
github-merge-queue bot pushed a commit that referenced this issue Feb 28, 2025
@HeinrichApfelmus
Add dependency constraints on launcher (#5007)
ab0b709 
This pull request adds dependency constraints to the `launcher` package,
as this package is a likely target for releasing on CHaP.

Where appropriate, we also remove the direct dependency on the following
packages

* `either`
* `extra`

because these dependencies do not cross the [Fairbairn
threshold](https://wiki.haskell.org/Fairbairn_threshold).

### Issues

#4958
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HeinrichApfelmus HeinrichApfelmus

Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
2025Q1
Development

No branches or pull requests
2 participants
@abailly @HeinrichApfelmus