Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate docker image push on release CI pipeline #4900

Closed
Tracked by #4917
paolino opened this issue Jan 6, 2025 · 1 comment · Fixed by #4937
Closed
Tracked by #4917

Automate docker image push on release CI pipeline #4900

paolino opened this issue Jan 6, 2025 · 1 comment · Fixed by #4937
Assignees
Labels
CI CI related Improvement Mark a PR as an improvement, for auto-generated CHANGELOG
Milestone

Comments

@paolino
Copy link
Collaborator

paolino commented Jan 6, 2025

Why

The release pipeline should automate all possible steps. ATM it’s able to push images to docker-hub, but the release tag is not pushed

What

Make it possible when unblocking the release block on the release pipeline the released tag is pushed to docker-hub
By running this step, docker-hub will be populated before the release actually happened. Rolling back the change is
not automatable, as we cannot delete images on our own from docker hub and we have to open a ticket.
So the best solution is to have a separate block that control the push to dockerhub

Acceptance

A new blocked step is added to the release pipeline that gives the user the chance to publish the wallet image to dockerhub

Issues

#4917

@paolino paolino added Improvement Mark a PR as an improvement, for auto-generated CHANGELOG CI CI related labels Jan 6, 2025
@paolino paolino self-assigned this Jan 6, 2025
@abailly
Copy link
Collaborator

abailly commented Jan 6, 2025

An alternative could be to keep intermediate images in GH and only push truly released version to docker hub for better visibility. Note that buildkite also proposed docker images registries

@paolino paolino added this to the 2025Q1 milestone Jan 9, 2025
github-merge-queue bot pushed a commit that referenced this issue Jan 13, 2025
### Changes

- [x] Move the push to dockerhub step from the main pipeline to the
release one in the nightly group
- [x] Use a bash script that collect the image from the artifacts to
push to dockerhub and respect `test` and `nightly` tags
- [x] Ditch the nix solution to push to dockerhub
- [x] Add a block before pushing the release tag to dockerhub

### Issues

fix #4900
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI related Improvement Mark a PR as an improvement, for auto-generated CHANGELOG
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants