Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added starknet foundry support + demonstration tests #20

Merged

Conversation

thomas192
Copy link
Contributor

PR related to issue #13

Copy link
Collaborator

@cloudvenger cloudvenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

I just bump the version from 0.17.0 to 0.17.1 for foundry

@cloudvenger
Copy link
Collaborator

@thomas192 how much time did you take to do this PR ?

@cloudvenger cloudvenger merged commit da4d0fc into carbonable-labs:main Mar 19, 2024
1 check passed
@thomas192
Copy link
Contributor Author

Nice work 👍

I just bump the version from 0.17.0 to 0.17.1 for foundry

Thanks 🙂

@thomas192 how much time did you take to do this PR ?

I have limited experience so it took me ~2 hours.
I also wanted to have a good grasp of what was going on, so I started reading the carbon protocol contracts this weekend (~5/6 hours over a couple days).

@tekkac
Copy link
Contributor

tekkac commented Jun 6, 2024

closes #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants