fix(tag): allow on:close
to work with Svelte 5
#2097
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2096
Interestingly,
<Tag filter on:close />
does not fire because the forwardedon:click
uses thestopPropagation
modifier.Removing it allows the dispatched "close" event to fire.
on:close
is effectively an alias foron:click
, which is only forwarded to the button for a filterable tag.Expected
Both "click" and "close" should be logged.
Expected
If the consumer manually stops propagation, "click" is logged but "close" will not. This works in Svelte 5, but not Svelte 4.