fix(types): loosen icon prop type to any
#2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metonym
force-pushed
the
fix-icon-type-svelte-5
branch
from
e07c74d to
c667d98
Compare
metonym
changed the title
icon prop type to support Componenticon prop type to any
|
Released in v0.87.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
carbon-design-system/carbon-icons-svelte#207
carbon-icons-svelte@13andcarbon-pictograms-svelte@13now only offer TypeScript support Svelte 4/5.However, the new
Componenttype is incompatible withiconprop types in thecarbon-components-sveltelibrary. If using Svelte 5, a type error is shown for theiconprop, sincetypeof SvelteComponentis not compatible with the newComponenttype from Svelte 5.Unfortunately,
Componentis not available in Svelte 3 or 4. For this library to be compatible with Svelte 3, 4, and 5, this PR loosens theiconprop type toany.Note that the previous type
typeof import("svelte").SvelteComponent<any>effectively typed it as "any" anyway.