fix(batch-predictor, pyfunc-server): Pin setuptools max version #608
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems like from the 20th of September 2024, CICD tasks that require building a python environment started failing with the following error when the ancient
mlflow
package tries to log artifacts:This seems to be an error reported recently by other people in the
pyinstaller
repo, with some users mentioning thatdistutils
is used bysetuptools
, which just had a new version released recently. Since it doesn't seem like we're importingdistutils
directly, I've decided to simply pin down the max version ofsetuptools
to<75
. Note that the version ofsetuputils
somehow needs to be specified in the variable passed to this argumentinstall_requires
heremerlin/python/pyfunc-server/setup.py
Line 49 in a9184ed
As such, I've added
setuptools<75
in both the batch predictor and pyfunc server's requirements.txt file.Note that this PR technically does not fix the root cause of the problem; it's only a band-aid solution for the moment until we migrate to newer versions of Mlflow very shortly. When that happens I'll revert the changes in this PR.
Modifications
.github/workflows/release.yml
- Updated the versions ofsetuptools
in the build jobs for the python-related componentspython/batch-predictor/requirements.txt
- Addedsetuptools<75
to the requirements of the batch predictorpython/pyfunc-server/requirements.txt
- Addedsetuptools<75
to the requirements of the pyfunc serverTests
Checklist
Release Notes