-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model deployment support for model observability #492
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9347914
to
cbf6a4d
Compare
krithika369
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR and the detailed description, @tiopramayudi! Left some small comments - the rest LGTM.
khorshuheng
reviewed
Nov 29, 2023
The e2e test failed because of:
|
Need to merge this PR first |
4ef0262
to
e97a045
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In the previous PR we introduce
PyFuncV3Model
to support model observability use case. What missing from previous PR is deployment process ofPyFuncV3Model
, hence this PR is raised.Modification:
api/config/config.go
- AddingPyFuncPublisherConfig
new configuration for pyfunc publisherapi/config/environment.go
- Update parsingDeploymentConfig
to add relevant config to the deployment configdb-migrations/34_version_endpoints_enable_observability.*.sql
- Adding model observability enable flag to version endpointapi/models/model.go
- Addingpyfunc_v3
model typeapi/cluster/resource/templater.go
deploymentConfig
including standard transformer configurationPyFuncV3Model
api/api/version_endpoints_api.go
- AddingPyFuncV3Model
as supported model type for UPIpython/sdk/test/pyfunc_integration_test.py
- Adding integration test forPyFuncV3Model
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:
Checklist