Fix slice row ui when delete entry in start or end index (#239)

Co-authored-by: Tio Pramayudi <[email protected]>
caraml-dev · Apr 12, 2022 · feb9cef · feb9cef
1 parent 55a1c7a
commit feb9cef
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...s/version/components/forms/components/transformer/components/table_operations/SliceRow.js b/...s/version/components/forms/components/transformer/components/table_operations/SliceRow.js
@@ -26,7 +26,7 @@ export const SliceRow = ({ sliceRow, onChangeHandler, errors = {} }) => {
           fullWidth>
           <EuiFieldText
             placeholder="Start Index"
-            value={!!sliceRow && sliceRow.start ? sliceRow.start : "null"}
+            value={!!sliceRow && sliceRow.start ? sliceRow.start : ""}
             onChange={e => onChange("start")(e.target.value)}
             isInvalid={!!errors.name}
             name={`start`}
@@ -48,7 +48,7 @@ export const SliceRow = ({ sliceRow, onChangeHandler, errors = {} }) => {
           fullWidth>
           <EuiFieldText
             placeholder="End Index"
-            value={!!sliceRow && sliceRow.end ? sliceRow.end : "null"}
+            value={!!sliceRow && sliceRow.end ? sliceRow.end : ""}
             onChange={e => onChange("end")(e.target.value)}
             isInvalid={!!errors.name}
             name={`end`}

diff --git a/ui/src/services/transformer/TransformerConfig.js b/ui/src/services/transformer/TransformerConfig.js
@@ -419,10 +419,10 @@ export class Pipeline {
             }
             if (step.operation === "sliceRow") {
               if (step.sliceRow) {
-                if (step.sliceRow.start) {
+                if (step.sliceRow.start !== undefined) {
                   step.sliceRow.start = parseInt(step.sliceRow.start);
                 }
-                if (step.sliceRow.end) {
+                if (step.sliceRow.end !== undefined) {
                   step.sliceRow.end = parseInt(step.sliceRow.end);
                 }
               }