Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove merlin sdk from user's conda.yaml (#495)
<!-- Thanks for sending a pull request! Here are some tips for you: 1. Run unit tests and ensure that they are passing 2. If your change introduces any API changes, make sure to update the e2e tests 3. Make sure documentation is updated for your PR! --> **What this PR does / why we need it**: <!-- Explain here the context and why you're making the change. What is the problem you're trying to solve. ---> After releasing Merlin 0.36.0-rc3 that include pyfunc_v3 to support model observability features, users that have merlin-sdk as explicit dependencies in their conda.yaml will get following error: ``` ImportError: cannot import name 'PyFuncOutput' from 'merlin.pyfunc' ... ``` This error is caused because the pyfunc and batch prediction job base image is installing local version of merlin-sdk (tag v0.36.0-rc3) that have PyFuncOutput and other classes. However, during image building, conda will install latest stable version of Merlin (namely 0.35.3) which will override the local version of merlin-sdk and raise that error. This PR removes merlin-sdk in user's conda.yaml, from this: ``` name: merlin-model dependencies: - python=3.8 - pip=22.2.2 - pip: - mlflow - merlin-sdk - merlin-sdk==0.35.0 - merlin-sdk<0.35.0 - merlin-sdk>0.35.0 - merlin-sdk<=0.35.0 - merlin-sdk>=0.35.0 - merlin-sdk>0.35.0,<0.36.0 - merlin-sdk>=0.35.0,<0.36.0 - merlin-sdk>0.35.0,<=0.36.0 - merlin-sdk>=0.35.0,<=0.36.0 ``` to this: ``` name: merlin-model dependencies: - python=3.8 - pip=22.2.2 - pip: - mlflow==1.26.1 ``` **Which issue(s) this PR fixes**: <!-- *Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Fixes error image building if user specified merlin-sdk without version in their conda.yaml **Does this PR introduce a user-facing change?**: <!-- If no, just write "NONE" in the release-note block below. If yes, a release note is required. Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required". For more information about release notes, see kubernetes' guide here: http://git.k8s.io/community/contributors/guide/release-notes.md --> ```release-note ``` **Checklist** - [ ] Added unit test, integration, and/or e2e tests - [x] Tested locally - [ ] Updated documentation - [ ] Update Swagger spec if the PR introduce API changes - [ ] Regenerated Golang and Python client if the PR introduce API changes
- Loading branch information