fix(mlflow): Remove redundant Mlflow extra envs mapping #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In PR #426, modifications were made to the Mlflow deployment template in order to allow it to be configured with additional environment variables specified under the
extraEnvsfield.However that was problematic as there was already an existing template block that already parses the values of
extraEnvsas environment values in the deployment template.See the following lines:
This PR cleans up the previous template block for the
extraEnvsfield in favour of the new one, which is simpler.Modification
charts/merlin/templates/mlflow-deployment.yaml- removal of a redundant block to parse environment variablesChecklist