Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: option for rbac creation #428

Merged
merged 2 commits into from
Jan 2, 2025
Merged

feat: option for rbac creation #428

merged 2 commits into from
Jan 2, 2025

Conversation

mbruner
Copy link
Member

@mbruner mbruner commented Jan 2, 2025 •
edited
Loading

Motivation

Allow enabling RBAC creation from values even when we don't use in-cluster config.

Modification

Checklist

  • Chart version bumped
  • README.md updated

@mbruner mbruner requested a review from a team as a code owner January 2, 2025 08:11
@mbruner mbruner requested review from deadlycoconuts and removed request for a team January 2, 2025 08:11
deadlycoconuts
deadlycoconuts approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@deadlycoconuts deadlycoconuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for these changes! Could you also make the exact same changes on Turing too? I think we'll end up having to fix the same issue there also 😅 Thanks!

@mbruner mbruner changed the title feat(merlin): option for rbac creation feat: option for rbac creation Jan 2, 2025
@mbruner mbruner merged commit f60a41a into main Jan 2, 2025
4 checks passed
@mbruner mbruner deleted the merlin-role branch January 2, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deadlycoconuts deadlycoconuts deadlycoconuts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbruner @deadlycoconuts