Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix type for extra volume mount #418

Merged
merged 1 commit into from
May 23, 2024
Merged

feat: fix type for extra volume mount #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/config/ct.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# See https://github.com/helm/chart-testing#configuration
remote: origin
target-branch: add-feast-ui-chart
target-branch: main
chart-dirs:
- charts
chart-repos:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ jobs:
fi

- name: Run chart-testing (install)
run: ct install --config .github/config/ct.yaml --excluded-charts kserve,common --print-config
run: ct install --config .github/config/ct.yaml --excluded-charts kserve,common,feast-ui --print-config

- name: Run chart-testing for kserve (install)
env:
Expand Down
2 changes: 1 addition & 1 deletion charts/feast-ui/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
description: "Feast: ML Feature Store"
name: feast-ui
version: 0.5.0
version: 0.5.1
maintainers:
- email: [email protected]
name: caraml-dev
6 changes: 3 additions & 3 deletions charts/feast-ui/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# feast-ui

![Version: 0.5.0](https://img.shields.io/badge/Version-0.5.0-informational?style=flat-square)
![Version: 0.5.1](https://img.shields.io/badge/Version-0.5.1-informational?style=flat-square)

Feast: ML Feature Store

Expand All @@ -14,8 +14,8 @@ Feast: ML Feature Store

| Key | Type | Default | Description |
|-----|------|---------|-------------|
| feast_ui.extraVolumeMounts | object | `{}` | |
| feast_ui.extraVolumes | object | `{}` | |
| feast_ui.extraVolumeMounts | list | `[]` | |
| feast_ui.extraVolumes | list | `[]` | |
| feast_ui.image.pullPolicy | string | `"IfNotPresent"` | |
| feast_ui.image.registry | string | `""` | |
| feast_ui.image.repository | string | `"feast-ui"` | |
Expand Down
4 changes: 2 additions & 2 deletions charts/feast-ui/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ feast_ui:
internalPort: 8080


extraVolumes: {}
extraVolumes: []

extraVolumeMounts: {}
extraVolumeMounts: []

livenessProbe:
path: "/api/live"
Expand Down
Loading