sofia2 in the line worker #1624
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Should take care of #1320. |
dane-kleiner
commented
Feb 18, 2025
| @@ -208,11 +208,14 @@ def calc_rms(filename, linemaskname): | |||
| return np.sqrt(np.sum(y * y, dtype=np.float64) / y.size) | |||
| else: | |||
| with fits.open(filename) as cube: | |||
| datacube = cube[0].data | |||
There was a problem hiding this comment.
This part has been modified because I believe that sofia2 saves cubes without (whereas sofia kept) the stokes axis , so this makes sure the cube and clean_mask have the same dimensions to do this calculation. @paoloserra
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sofia-2 with many more options to replace sofia. It requires the latest Stimela to test -- An update was needed to fix the handling of one of the sofia settings.
The current set up is that any sofia-2 input file (e.g. own mask, flagging catalogue) needs to be in the same directory as the input cube. This can be changed, I'm not sure it makes it better -- happy to discuss. If using Sofia-2 for making a clean mask with wscl + sofia, the output of the source finding is put in the output directory of the cube it was run on. If do_sourcefinding is true, then the outputs are put into its own sofia directory where the input cube is.