Improvements #195
Improvements #195
Conversation
throw new error removed the error object which contain actual error details from server
made prepareAndStoreKeyShares into smaller function which uses prepareStoreablePayloadForShares this can be used to prepare shares to be stored with signing added identifyAndStoreFailedShares which takes data from prepareAndStoreKeyShares and retry with only failed items naming convention improvememnts
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -87,6 +87,9 @@ export type TeeSharesStoreType = { | |||
| enclaveAddress: string | |||
| operatorAddress: string | |||
| enclaveSlot: number | |||
There was a problem hiding this comment.
I'm not sure anyone uses this type outside of the SDK itself, but those new additions must be marked as breaking changes in case.
| @@ -55,8 +55,8 @@ export const retryPost = async <T>(fn: () => Promise<any>, n: number): Promise<T | |||
| } catch (err: any) { | |||
| lastError = { | |||
| isRetryError: true, | |||
| status: "SDK_RETRY_POST_ERROR", | |||
| message: err?.message ? err.message : JSON.stringify(err), | |||
| status: err.status, | |||
There was a problem hiding this comment.
Updating the status with a proper status 500 from HTTP is a breaking change. If the function is successful, it will return the enclave status which is a string: STORESUCCESS, DATABASEFAILURE, KEYNOTEXIST (...) while it will be a Number in case of failure. The developer will have to filter the type if handling the response is needed.
There was a problem hiding this comment.
I have changed it so internal status is now a string on fail
src/helpers/tee.ts
Outdated
| if (kind !== "secret" && kind !== "capsule") { | ||
| throw new Error(`${Errors.TEE_ERROR}: Kind must be either "secret" or "capsule"`) | ||
| } | ||
| const teeEnclaves = await getTeeEnclavesBaseUrl(clusterId) | ||
| let isShareAvailable = false | ||
| let i = 0 | ||
| while (isShareAvailable !== true && i <= teeEnclaves.length - 1) { | ||
| console.log("checking enclave i", i, "---", teeEnclaves[i]) |
src/helpers/tee.ts
Outdated
| } | ||
| }), | ||
| ) | ||
|
|
||
| shares = shares.filter((x) => x !== undefined) | ||
| if (shares.length < SSSA_THRESHOLD) { | ||
| throw new Error(`${Errors.TEE_RETRIEVE_ERROR} - Shares could not be retrieved: ${errors[0]}`) | ||
| throw { error: `${Errors.TEE_RETRIEVE_ERROR} - Shares could not be retrieved`, details: errors } |
There was a problem hiding this comment.
I'm not sure anyone uses this fn outside of Ternoa's internal use, but this exception object replacing the string error, might need to be marked as breaking changes in case.
There was a problem hiding this comment.
reverted to be string as before
| }), | ||
| ) | ||
|
|
||
| return teeRes.map((enclaveRes, i) => { | ||
| const payload = payloads[i] | ||
| return teeRes.map((enclaveRes) => { |
There was a problem hiding this comment.
the returned structure looks good and not breaking change. Just more additions
src/helpers/http.ts
Outdated
| throw new Error(err) | ||
| if (err.response) throw { status: err.response.status, data: err.response.data } | ||
| throw { status: 500, data: "ECONNREFUSED", error: err } | ||
| // throw new Error('url:' + url + ' Error:' + err) |
There was a problem hiding this comment.
this new answer structure should be considered and marked as a breaking change from a developer's pov.
Same for the two remaining ones.
Description
Related Issue
Types of changes