Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rowCount for db operations #271

Closed
wants to merge 7 commits into from
Closed

Conversation

soccermax
Copy link
Contributor

No description provided.

@yevgentrukhin
Copy link

Can you use semantic convention: https://opentelemetry.io/docs/specs/semconv/database/database-metrics/#metric-dbclientresponsereturned_rows ?

@soccermax
Copy link
Contributor Author

Can you use semantic convention: https://opentelemetry.io/docs/specs/semconv/database/database-metrics/#metric-dbclientresponsereturned_rows ?

Oh didn't know. Sure, thanks

@johannes-vogel johannes-vogel requested a review from sjvans January 9, 2025 10:02
@sebastien-savalle
Copy link

Would it be possible to follow dynatrace semantic in order to display those information in the dynatrace database view (fetches and rows affected) ?

Like in this example
image

@soccermax
Copy link
Contributor Author

Would it be possible to follow dynatrace semantic in order to display those information in the dynatrace database view (fetches and rows affected) ?

Like in this example image

same problem: #275
IMO dynatrace does not display the traces the right way even though the should have all the infos they need

@sjvans sjvans mentioned this pull request Jan 9, 2025
2 tasks
@sjvans
Copy link
Contributor

sjvans commented Jan 9, 2025

let's follow up via #276 (non-fork version of this pr)

@sjvans sjvans closed this Jan 9, 2025
sjvans added a commit that referenced this pull request Jan 9, 2025
non-fork version of #271

- [x] tests
- [x] changelog entry

---

thanks @soccermax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants