feat: logs via otel #249
Merged
feat: logs via otel #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sjvans
commented
Nov 6, 2024
•
sjvans
commented
sjvans
commented
Nov 6, 2024
lib/logging/index.js
Outdated
Comment on lines
88
to
94
| // TODO: what to log? | ||
| logger.emit({ | ||
| severityNumber: SeverityNumber[severity], | ||
| severityText: severity, | ||
| body: log.msg, | ||
| attributes: { 'log.type': 'LogRecord' } | ||
| }) |
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
additional some semantic conventions from CPA come to mind... (hope it is ok to post SAP-internal references here in a comment, otherwise I remove them again :))
e.g. https://github.tools.sap/CPA/telemetry-semantic-conventions/blob/main/sap-extensions/logs/trace-correlation.md
or something from here? https://github.tools.sap/CPA/telemetry-semantic-conventions/blob/main/sap-extensions/resource/service.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.