Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove questionable test #185

Closed
wants to merge 1 commit into from
Closed

chore: remove questionable test #185

wants to merge 1 commit into from

Conversation

danjoa
Copy link
Contributor

@danjoa danjoa commented Oct 7, 2024 •
edited
Loading

Required for new cds.i18n

@danjoa danjoa requested a review from a team as a code owner October 7, 2024 07:58
@schwma schwma mentioned this pull request Oct 7, 2024
Merged
schwma
schwma requested changes Oct 7, 2024
View reviewed changes
Copy link
Member

@schwma schwma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created a PR to fix this test by using an i18n string without placeholders when running req.reject without args: #186

@schwma schwma closed this in #186 Oct 9, 2024
schwma added a commit that referenced this pull request Oct 9, 2024
@schwma
test: remove undocumented and undefined usage of req.reject (#186)
a204b12 
fixes issue mentioned in #185

(closes #185)
@schwma schwma deleted the tests-cleanup branch October 24, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schwma schwma schwma requested changes

@David-Kunz David-Kunz Awaiting requested review from David-Kunz

@sjvans sjvans Awaiting requested review from sjvans

@johannes-vogel johannes-vogel Awaiting requested review from johannes-vogel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danjoa @schwma