Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periodic Events #44

Merged
merged 26 commits into from
Nov 14, 2023
Merged

Periodic Events #44

merged 26 commits into from
Nov 14, 2023

Conversation

soccermax
Copy link
Contributor

@soccermax soccermax commented Nov 10, 2023

fix #14

  • add new eventType: periodic events
  • periodicity should be defined every X seconds in yaml
  • during startup check persistence and schedule jobs
  • during selection - check that there is always one open entry
  • period jobs should have no status
  • check that there are no duplicated event type registrations
  • check period event registrations --> much less parameters
  • validations period not too small
  • also add event registration parameters for normal events
  • handle onboardings
  • do an extra run to schedule again for next processing - or maybe direclty during publish
  • test what happens if run is longer than interval
  • periodicEventOffset is currently not used anymore - delete?
  • publish should not allow periodic events

handle next:

  • variable to skip run if already running
  • periodic without tenant context (maybe do in next iteration)
  • add info to documentation
  • what is with load - rework complete load parameter for ad-hoc redis events and so on
  • allow duplicate usage if ad hoc and periodic
  • parameter to deactivate periodic event runner (for e.g. local use cases)
  • how to handle longer downtime (deployment)
  • lock is still blocked if tick is overdue

@soccermax soccermax merged commit f51ae54 into main Nov 14, 2023
6 checks passed
@soccermax soccermax deleted the fb/periodicEvents branch November 14, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement new eventType - periodic events
1 participant