-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rich horizontal list): Rich horizontal list pattern #5456
Conversation
@lyubomir-popov I've completed an initial draft of this pattern's implementation. Per a discussion we had a few days ago, I want to draw your attention to one difference from the Figma design. We built the horizontal section component with intrinsic container queries to demo those. These container queries are not (nor should they be) aligned with the screen-level responsive breakpoints, so the horizontal section list changes column counts at different breakpoints than the rest of the pattern. This results in a small range where there are four list columns but the CTA has been moved to the first column due to reaching tablet size Screencast.from.2025-01-23.16-31-04.webmAlso, the logo section breaks out of the 50/50 split on tablet size, before the column counts have changed: Screencast.from.2025-01-23.16-32-16.webmI would add that this isn't really a "bug", rather it is a feature of intrinsic sizing as components are sized independently from eachother based on their contents. It is just a bit interesting to see this behavior when we combine elements built with container and media queries. Is this acceptable? If not, we can make an adjustment to the horizontal section so that it uses the responsive grid instead of container queries. |
Absolutely. That's the beauty of container queries. Nice work! |
c1b45ab
to
9d1729d
Compare
e61fd33
to
e73cc7a
Compare
Left one comment on figma, the h2 needs a p-section--shallow wrapper. all good apart from that, nice work! |
…tem styling documentation section showing different list item options
…r small readability tweaks
0dfe9ba
to
a073e0c
Compare
per @lyubomir-popov design review
A code reviewer from the sites team is being assigned, per @petesfrench |
templates/docs/examples/patterns/rich-list-horizontal/ordered-responsive.html
Outdated
Show resolved
Hide resolved
Thanks for the reviews @britneywwc ! I've addressed all of your comments, could you have another look please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes @jmuzina, looks great! :)
Done
Fixes WD-17706
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver conventionScreenshots