Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copied the list flag from gocheck. #242

Merged
merged 1 commit into from
Mar 17, 2016
Merged

Copied the list flag from gocheck. #242

merged 1 commit into from
Mar 17, 2016

Conversation

come-maiz
Copy link
Contributor

Because gocheck doesn't let us extend the results reporter, we are doing a hacky solution to overwrite the output. This means that every time we need a new flag from gocheck, we need to copy it.
I'm starting to work on the upstream change to report subunit results, but that's not easy to do in go check. The certification team needs the list command, so I'm going with the quick solution while we finish the correct one.

@fgimenez
Copy link
Contributor

mmm IMO we don't need to get this far, this way we are going to list the tests inside a running testbed, and for that we need to build it and wait for it to boot. Maybe it would be easier to list them from the host, after the binary has been built in main.go, what do you think?

@fgimenez
Copy link
Contributor

👍 this works too from the host, but you need to build manually the binary and then call it with -gocheck.list, sorry for not getting that before. Do you think that we sould add a list script? something like

go test -c ./integration-tests/tests -o ./integration-tests/bin/integration.test && ./integration-tests/bin/integration.test -gocheck.list

@niemeyer
Copy link
Contributor

niemeyer commented Jan 5, 2016

Folks, I don't have enough context for these changes, but it sounds like there's some pending conversation from a month ago. Can you please sync up with each other and report back on your understanding of the way forward here?

@niemeyer
Copy link
Contributor

This is open for a month, and silent for a week. I'm closing it for the time being.. please feel free to reopen it when there is interest on the change again.

@come-maiz
Copy link
Contributor Author

I resurrected this hacky PR because @plars still needs it and Gustavo didn't reply in go-check/check#73 (comment)

@plars
Copy link
Contributor

plars commented Mar 16, 2016

+1 this is needed by some of my PRs that are waiting

@come-maiz
Copy link
Contributor Author

retest this please

@come-maiz
Copy link
Contributor Author

merge this please

come-maiz added a commit that referenced this pull request Mar 17, 2016
Copied the list flag from gocheck.
@come-maiz come-maiz merged commit 7db65ec into canonical:master Mar 17, 2016
@come-maiz come-maiz deleted the gocheck_list branch March 17, 2016 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants